Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM: Restore 50MB tmpfs for lxd-agent as it will likely exceed 25MB #13126

Merged
merged 1 commit into from
Mar 13, 2024
Merged

VM: Restore 50MB tmpfs for lxd-agent as it will likely exceed 25MB #13126

merged 1 commit into from
Mar 13, 2024

Conversation

tomponline
Copy link
Member

No description provided.

@tomponline
lxd/instance/drivers/driver/qemu: Restore 50MB tmpfs for lxd-agent as…
b25817c 
… it will likely exceed 25MB

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline self-assigned this Mar 13, 2024
@tomponline tomponline requested a review from simondeziel March 13, 2024 12:51
simondeziel
simondeziel reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather modify the build steps to not generate the debug symbols in the first place. Would that be OK with you?

@tomponline
Copy link
Member Author

I'd rather modify the build steps to not generate the debug symbols in the first place. Would that be OK with you?

No because even then it comes out at 21MB which doesn't give us enough leeway. I don't see the need to restrict it so low.

@tomponline tomponline merged commit c536dce into canonical:main Mar 13, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simondeziel simondeziel simondeziel approved these changes

Assignees

@tomponline tomponline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomponline @simondeziel