lxd: Improves efficiency of operation cancel with permission checker. #13156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
roosterfish
requested changes
Mar 15, 2024
Previously, each url was checked with `(Authorizer).CheckPermission`. With the fine-grained authorization driver this may use more database calls than is necessary. This commit refactors the permission check to use a permission checker instead, if there are multiple entities of a given type. (See similar logic in `lxd/project.FilterUsedBy`). Signed-off-by: Mark Laing <mark.laing@canonical.com>
markylaing
force-pushed
the
operation-cancel-permission-check
branch
from
102ad80
to
767b342
Compare
roosterfish
approved these changes
Mar 15, 2024
tomponline
reviewed
Mar 15, 2024
| @@ -257,14 +257,44 @@ func operationDelete(d *Daemon, r *http.Request) response.Response { | |||
| projectName = api.ProjectDefaultName | |||
| } | |||
|
|
|||
| // Separate resources by entity type. If there are multiple entries of a particular entity type we can reduce | |||
There was a problem hiding this comment.
Can we standardise this pattern into a helper function we can call in each appropriate place?
There was a problem hiding this comment.
This is similar to project.FilterUsedBy except that this one returns an error if any are unauthorized - rather than filtering them out.
I suppose here I could write a method FilterByEntitlement, then FilterUsedBy would call it with can_view and this function would call it and check if the length of the input list is equal to the length of the output list. I think that might be less clear though. Not sure 🤔
tomponline
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, each url was checked with
(Authorizer).CheckPermission. With the fine-grained authorization driver this may use more database calls than is necessary. This commit refactors the permission check to use a permission checker instead, if there are multiple entities of a given type. (See similar logic inlxd/project.FilterUsedBy).Partially addresses #12461 - see #12313 (comment)