scripts: Add bash completions for lxc auth
#13159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm vacillating over including idp-groups in the top-level completion (L198). I think `idp` ought to complete to idp-groups, but it makes `identity` less convenient. Happy to patch it. Resolves canonical#12989 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
|
I can't say that I understand the bash in this file all that well (I've never actually touched the bash completions before) but I'll try it out today :) |
|
Just want to check @simondeziel is happy with this. |
tomponline
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm vacillating over including
idp-groupsin the top-level completion (L198). I thinkidpought to complete toidp-groups, but it makesidentityless convenient. Happy to change it if needed.Resolves #12989
I've tested this pretty thoroughly but If @markylaing is willing to give them a quick spin I'd appreciate someone with a little more knowledge of the domain making sure they don't do anything too dumb.