Metrics: Add restricted and unrestricted certificate tests #13224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally check the responses if the endpoint gets queried using the project parameter as this is producing different results for restricted and unrestricted metrics certificates. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
|
@roosterfish so the tests are failing - thats expected right? That proves you're testing the issue and now we need to wait for #13214 to be merged and rebase to check it fixes it? |
My plan was that those succeed so that when we merge the other PR see that there wasn't a change in the metrics returned by the API. But looks there is as I wrote the test using the changes from the other PR. Let me check what is the delta here. |
|
It looks that when using a restricted metrics certificate the API currently returns nothing, same as when using OIDC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This precedes #13214 and is in another PR so that we can ensure we don't introduce any regressions with the PR.
Add tests to check the metrics responses for restricted and unrestricted certificates.
Additionally check if the endpoint gets queried using the project parameter as this is producing different results for restricted and unrestricted metrics certificates.