Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dormant/inactive tests #13554

Merged
merged 27 commits into from
Jun 10, 2024
Merged

Enable dormant/inactive tests #13554

merged 27 commits into from
Jun 10, 2024

Conversation

simondeziel
Copy link
Member

@simondeziel simondeziel commented Jun 5, 2024 •
edited
Loading

We currently have a few inactive test functions:

$ ./test/lint/test-tests.sh | grep ^\+test_
+test_clustering_upgrade
+test_clustering_upgrade_large
+test_image_import_existing_alias
+test_init_dump
+test_projects_copy
+test_remote_url_with_token

The new lint script ensures:

  • we don't try to skip required tests
  • we don't erroneously use a "test_" prefix for skipped or required tests
  • we run every existing test functions except those marked as skipped

@simondeziel simondeziel force-pushed the enable-more-tests branch 15 times, most recently from 406ee39 to a4395b1 Compare June 8, 2024 19:35
@simondeziel
test/suite/database: use a space between parenthesys and opening braket
b70ac32 
This aligns with the other test functions.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/main: export LXD_SKIP_TESTS
37c26bc 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/main: export LXD_REQUIRED_TESTS
d01ed85 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
github: use global vars to avoid dup'ing them between jobs
c0b70e9 
Drop bogus "test_" prefix in LXD_REQUIRED_TESTS

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/lint: add test to ensure all test cases are used
abf65a1 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test: enable test_clustering_upgrade
ea92f1c 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test: enable test_clustering_upgrade_large
de6fe4f 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/backup: rename internal sub-functions
b979443 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/fuidshift: rename internal sub-functions
1520436 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/container_devices_disk: rename internal sub-functions
d009b47 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/container_devices_unix: rename internal sub-function
1b07607 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/image_profiles: rename internal sub-function
595890f 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/config: rename internal sub-functions
56a29c3 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test: enable test_image_import_existing_alias
7350932 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test: enable test_init_dump
7607407 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test: enable test_projects_copy
5a3d90a 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test: enable test_remote_url_with_token
6900d9d 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/image: fix export/import from alias to cope with .tar.xz …
20dd2fa 
…extension

Also cleanup the exported file once done.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/serverconfig: rename internal sub-function
6a10160 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/remote: delete project at the end of test_remote_url_with…
a996d58 
…_token()

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/init_dump: remove network "managed: true" from expected c…
d578d1a 
…onfig dump

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/init_dump: add network "project: default" to expected con…
3ae1341 
…fig dump

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/init_dump: add storage_volumes list to expected config dump
7ab7243 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/init_dump: add projects section to expected config dump
89d462a 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/init_dump: mangled the dumped trust_password value
6c0265d 
It is not clear when the dump format changed but since the
`core.trust_password` support is going away
(canonical#13567), let's not bother with it for
now.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/remote: update expected behavior when accessing restricte…
6d8e568 
…d projects

canonical#13539 changed the behavior so that
queries to projects that are not authorized will succeed but the instance list
will be empty.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
github: skip clustering upgrade tests (broken)
d7b8ad4 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
tomponline
tomponline approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomponline tomponline marked this pull request as ready for review June 10, 2024 07:03
@tomponline tomponline merged commit d5ec06f into canonical:main Jun 10, 2024
29 checks passed
@simondeziel simondeziel deleted the enable-more-tests branch June 10, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simondeziel @tomponline