Device: Support long device names for host path passthrough to VMs #13603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
changed the title
|
@hamistao @roosterfish ready for review, thanks |
tomponline
changed the title
hamistao
reviewed
Jun 14, 2024
|
@tomponline The way I see it it is impossible to escape from the problem regarding the |
…ice of devlxd events But only when performing device actions against instances which are running. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…vicesUpdate in Update Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…evicesUpdate in Update Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…ount tag for mounting inside guest Then use the returned mount tag and add it to the mount options returned in RunConfig from deviceStart. This will allow it to be passed to the guest as an event when hot plugging a disk filesystem share. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…eviceStart in devicesUpdate and pass to devlxd event Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…k devices This ensures that if a disk device's mount tag is different from its name, because its name is too long or needs escaping, that it can stil be mounted. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…ice name when booting and hotplugging Fixes hot removal of boot time drive. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…o `hashIfLonger` Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit a0e0e52)
…DMaxLength` Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit dd8386d)
… to support long device names Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…ost drive to that used when hotplugging Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…or drive share daemons Allows use of supported "/" char in device names. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…ttachPath Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…lso do escaping So device names can container supported "/" chars. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…eName Where escaping was already taking place it has been removed. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
… to reflect new consistent fsdev and chardev naming Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/characters.mount_taginfo so that lxd-agent doesn't assume the mount tag is the device name.Unfortunately due to the historic setup of these devices it has been impossible to maintain complete backward compatibility with the mount tag formats. For short and simple names they remain the same, but for longer ones or ones with
/the mount tag has changed necessarily to support that functionality.Closes #13596