Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/suites/backup: cleanup #13745

Merged
merged 10 commits into from
Jul 14, 2024
Merged

test/suites/backup: cleanup #13745

merged 10 commits into from
Jul 14, 2024

Conversation

simondeziel
Copy link
Member

No description provided.

@simondeziel simondeziel force-pushed the optimized-storage-backup-tests branch 2 times, most recently from 29e914c to d7b9dd9 Compare July 11, 2024 20:38
@simondeziel
Copy link
Member Author

@roosterfish is this expected for a ceph optimized-storage export to have a different content? https://github.com/canonical/lxd/actions/runs/9898177190/job/27344367957?pr=13745#step:12:68468 shows a container/ dir instead of a container.bin file.

@simondeziel simondeziel requested a review from roosterfish July 12, 2024 00:22
@roosterfish
Copy link
Contributor

roosterfish commented Jul 12, 2024 •
edited
Loading

@roosterfish is this expected for a ceph optimized-storage export to have a different content?

Unlike zfs and Btrfs the Ceph RBD driver is using the generic backup creation method which ignores if an optimized backup is requested, see https://github.com/canonical/lxd/blob/main/lxd/storage/drivers/driver_ceph_volumes.go#L1864 which doesn't pass the optimized bool.

I have the feeling we should add this as a feature but for now maybe extend the table in https://documentation.ubuntu.com/lxd/en/latest/reference/storage_drivers/ with a Optimized backup row to clarify this, same as we did a few months ago with Optimized refresh?

simondeziel added 10 commits July 12, 2024 16:42
@simondeziel
test/includes/lxd: optimize spawn_lxd()
0a7e02c 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/includes/lxd: simplify kill_lxd()
bf85025 
Even `apparmor_parser` on 20.04 supports `--print-cache-dir` which is probably
the oldest distro we care about.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/includes/storage: optimize storage_backend()
ce8f1c5 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/includes/storage: add storage_backend_optimized_backup() helper
dca1948 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/backup: use storage_backend_optimized_backup() helper
b599c1e 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/backup: cleanup exported tarballs
d4770ff 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/backup: replace lxc rm by lxc delete
62022bf 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/backup: list content of untar'ed directory
aa9f112 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
doc/reference/storage_drivers: use emojies to ease reading
7e1aee7 
Emojies have long been displayable even on terminal( ✅ ❌ ➖ ) and they make
pattern recognition way easier.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
doc/reference/storage_drivers: add column for optimized backup suppor…
2a3e593 
…t (Btrfs/ZFS only)

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel force-pushed the optimized-storage-backup-tests branch from d7b9dd9 to 2a3e593 Compare July 12, 2024 20:43
@github-actions github-actions bot added the Documentation Documentation needs updating label Jul 12, 2024
@github-actions GitHub Actions
Copy link

Heads up @ru-fu - the "Documentation" label was applied to this issue.

@simondeziel simondeziel mentioned this pull request Jul 12, 2024
Open
@simondeziel
Copy link
Member Author

simondeziel commented Jul 12, 2024 •
edited
Loading

@roosterfish is this expected for a ceph optimized-storage export to have a different content?

Unlike zfs and Btrfs the Ceph RBD driver is using the generic backup creation method which ignores if an optimized backup is requested, see https://github.com/canonical/lxd/blob/main/lxd/storage/drivers/driver_ceph_volumes.go#L1864 which doesn't pass the optimized bool.

I see, thanks! #13753

I have the feeling we should add this as a feature but for now maybe extend the table in https://documentation.ubuntu.com/lxd/en/latest/reference/storage_drivers/ with a Optimized backup row to clarify this, same as we did a few months ago with Optimized refresh?

Done and I took the opportunity to add some colors to the table ;)

https://canonical-ubuntu-documentation-library--13745.com.readthedocs.build/lxd/en/13745/reference/storage_drivers/

@simondeziel simondeziel changed the title test/suites/backup: ceph supports --optimized-storage too test/suites/backup: cleanup Jul 12, 2024
@simondeziel simondeziel marked this pull request as ready for review July 12, 2024 22:06
@simondeziel simondeziel requested a review from tomponline as a code owner July 12, 2024 22:06
@tomponline tomponline merged commit 8830297 into canonical:main Jul 14, 2024
29 checks passed
@simondeziel simondeziel deleted the optimized-storage-backup-tests branch July 14, 2024 22:23
@ru-fu ru-fu mentioned this pull request Jul 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

@roosterfish roosterfish Awaiting requested review from roosterfish

Assignees
No one assigned
Labels
Documentation Documentation needs updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simondeziel @roosterfish @tomponline