Container: fix all apparmor ro+remount rules #13826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While investigating canonical#13810 I found that all ro+remount rules in the form: mount options=(ro,remount,bind,A,B,C) /some_pattern{,/**}, just does not work at all. This remount+bind case is a very special one, and we should rewrite all rules in this form: mount options=(ro,remount,bind,A,B,C) -> /some_pattern{,/**}, This syntax is not new. This change should be compatible with very old AppArmor versions including 2.11. Explanation why it was not noticed for years is that for unprivileged container case we have analogical rule but in a wider form: mount options=(ro,remount,bind,nodev,A,B,C), which masks the issue. But for privileged containers it's not. So, let's fix this for correctness. Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
|
cc @jrjohansen |
tomponline
changed the title
|
@mihalicyn nice! Does this fix any specific GH issue (like the Oracular issue for privileged containers)? |
tomponline
approved these changes
Jul 26, 2024
this PR definitely makes things better for privileged containers, but does not fix the issue. So we need this change, but it's not a final point. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #13810 I found that all ro+remount rules in the form:
just does not work at all. This remount+bind case is a very special one, and we should rewrite all rules in this form:
This syntax is not new. This change should be compatible with very old AppArmor versions including 2.11.
Explanation why it was not noticed for years is that for unprivileged container case we have analogical rule but in a wider form:
which masks the issue. But for privileged containers it's not.
So, let's fix this for correctness.