Migration: Forward migration errors (from Incus) #13966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boltmark
force-pushed
the
forward-migration-err
branch
from
79bd0f0
to
f755c37
Compare
masnax
reviewed
Aug 22, 2024
boltmark
force-pushed
the
forward-migration-err
branch
2 times, most recently
from
a4622fb
to
dc91860
Compare
tomponline
reviewed
Aug 27, 2024
tomponline
reviewed
Aug 27, 2024
tomponline
reviewed
Aug 27, 2024
tomponline
reviewed
Aug 27, 2024
tomponline
reviewed
Aug 27, 2024
boltmark
force-pushed
the
forward-migration-err
branch
4 times, most recently
from
82d24c1
to
f249c75
Compare
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit 47310d37446077f9606705a6736952fae1ae5869) Signed-off-by: Mark Bolton <mark.bolton@canonical.com> License: Apache-2.0
boltmark
force-pushed
the
forward-migration-err
branch
from
f249c75
to
433a231
Compare
boltmark
changed the title
|
@tomponline I've updated this PR to cherry-pick the incus fix. Marking as ready. |
Signed-off-by: Mark Bolton <mark.bolton@canonical.com>
boltmark
force-pushed
the
forward-migration-err
branch
from
3588c32
to
398d6ae
Compare
tomponline
approved these changes
Aug 29, 2024
hamistao
pushed a commit
to hamistao/lxd
that referenced
this pull request
Aug 30, 2024
This PR adds functionality to report source errors during copy. This helps to solve the issue of the incorrect error being reported when a live migration is attempted while `migration.stateful` is missing or set to false. (Also rectifies a few unchecked type assertions in `client/lxd_instances.go` since the linter complained) Closes canonical#11948.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to report source errors during copy. This helps to solve the issue of the incorrect error being reported when a live migration is attempted while
migration.statefulis missing or set to false.(Also rectifies a few unchecked type assertions in
client/lxd_instances.gosince the linter complained)Closes #11948.