Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiles & instance listing efficency improvements (from Incus) #14315

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Profiles & instance listing efficency improvements (from Incus) #14315

merged 9 commits into from
Oct 21, 2024

Conversation

hamistao
Copy link
Contributor

@hamistao hamistao commented Oct 21, 2024 •
edited
Loading

Improves listing profiles/instances by caching some data on the entities and making DB queries way more efficient.

Contains cherry picks from lxc/incus#1140 and lxc/incus#1314.

@MggMuggins

@hamistao hamistao force-pushed the improve_listing_profiles_instances branch 2 times, most recently from 9bd992a to 69f8d96 Compare October 21, 2024 15:25
@stgraber @hamistao
lxd/db/cluster/profiles: Support device cache in ToAPI
ea10a89 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: https://webdock.io
(cherry picked from commit edcea63a7604786a9fe5396022f8a5b9cd02560f)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
License: Apache-2.0
@stgraber @hamistao
lxd: Pass profile device cache to ToAPI calls when possible
16a0ca9 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: https://webdock.io
(cherry picked from commit db2a8cd1d136dc2463775b4066245576b7001fe7)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
License: Apache-2.0
@stgraber @hamistao
lxd/db/cluster/instances: Support device cache to ToAPI
5a2c9c7 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: https://webdock.io
(cherry picked from commit 3c886fc6b354f4f07a2b8bba1f798092c7084704)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
License: Apache-2.0
@stgraber @hamistao
lxd/project/limits: Pass instance device cache to ToAPI
bb2fe4b 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: https://webdock.io
(cherry picked from commit 5d46fd8efdaf27bba1033e08ddc52b07dac8f964)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
License: Apache-2.0
@stgraber @hamistao
lxd/db/cluster/instances: Allow passing profile devices to instance T…
9bffd16 
…oAPI

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: https://webdock.io
(cherry picked from commit 38d7c3087c235d59bf194333c766c975b48c6b3c)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
License: Apache-2.0
@stgraber @hamistao
lxd/project/limits: Pass profile device cache to instance ToAPI
65a4067 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: https://webdock.io
(cherry picked from commit caa997d50cb785d3c0489be59e46dd67b80b3880)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
License: Apache-2.0
@stgraber @hamistao
lxd/db/cluster/profiles: Support config caching
3bbf11c 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: https://webdock.io
(cherry picked from commit 06b59879623c03cf3e7c3b7cbd23df5b3ec82467)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
License: Apache-2.0
@stgraber @hamistao
lxd: Update calls to profile ToAPI
2be1d52 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: https://webdock.io
(cherry picked from commit 8f46deddeeadb68218d942cd8521259e278b241a)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
License: Apache-2.0
@stgraber @hamistao
lxd/db/cluster/profiles: Fix import shadowing
740a7f9 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: https://webdock.io
(cherry picked from commit 8261a78dd1134a7a41e704361b271b328c05388a)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
License: Apache-2.0
@hamistao hamistao force-pushed the improve_listing_profiles_instances branch from 69f8d96 to 740a7f9 Compare October 21, 2024 15:25
@hamistao
Copy link
Contributor Author

@tomponline @MggMuggins
I did not see the motivation for this, so I did not include it. Aside from this, this is working and should be ready to merge.

@hamistao hamistao marked this pull request as ready for review October 21, 2024 18:53
@tomponline
Copy link
Member

@tomponline @MggMuggins I did not see the motivation for this, so I did not include it. Aside from this, this is working and should be ready to merge.

Lets include that retry logic cleanup please

@hamistao hamistao mentioned this pull request Oct 21, 2024
Closed
@tomponline tomponline changed the title Profiles/instance listing efficency improvements Profiles/instance listing efficency improvements (from Incus) Oct 21, 2024
@tomponline tomponline changed the title Profiles/instance listing efficency improvements (from Incus) Profiles & instance listing efficency improvements (from Incus) Oct 21, 2024
@tomponline tomponline merged commit f8ddd2f into canonical:main Oct 21, 2024
29 checks passed
@MggMuggins MggMuggins mentioned this pull request Oct 21, 2024
Merged
@hamistao hamistao deleted the improve_listing_profiles_instances branch October 21, 2024 23:42
@markylaing markylaing mentioned this pull request Oct 23, 2024
Merged
1 task
tomponline added a commit that referenced this pull request Oct 24, 2024
@tomponline
Project limits: Use InstanceList (#14318)
ead3a69 
Follow-up to #14315

This tidies up the queries used for project limits checking; it likely
results in improved performance for clusters with many entities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamistao @tomponline @stgraber