Storage: Specify storage volume type in disk device source
#14491
+184
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MggMuggins
force-pushed
the
jira-2160/specify-storage-volume-type
branch
from
3eabf13
to
be19fcc
Compare
tomponline
reviewed
Nov 22, 2024
tomponline
reviewed
Nov 22, 2024
tomponline
reviewed
Nov 22, 2024
tomponline
reviewed
Nov 22, 2024
tomponline
reviewed
Nov 22, 2024
tomponline
reviewed
Nov 22, 2024
MggMuggins
force-pushed
the
jira-2160/specify-storage-volume-type
branch
from
be19fcc
to
3d0131e
Compare
MggMuggins
force-pushed
the
jira-2160/specify-storage-volume-type
branch
2 times, most recently
from
d546641
to
2e71130
Compare
3 tasks
This function: - Is not clearly named (it returns a path) - Is used in exactly one place - Does 1 uneeded DB query Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
This saves us 1 db query. Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
virtual-machine/container volumes in the default project do not include the project name. Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Allows device `source` property as `custom/name` Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
This section will be expanded for virtual-machine volumes later Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
MggMuggins
force-pushed
the
jira-2160/specify-storage-volume-type
branch
from
2e71130
to
7b9f6d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lays the groundwork for attaching VM root disk devices to instances by making two changes:
Refactor
Renames
(Un)MountCustomVolume->(Un)MountVolumeto allow for generic activation ofvirtual-machineandcontainervolumes.Specify volume type in disk device
Allows the following syntax for specifying
customstorage volumes in disk devices:(I was incorrect in my assessment that we already support this syntax; the code was there but wasn't being used consistently)