Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use single testing-library/dom #5209

Merged
merged 2 commits into from
Nov 16, 2023
Merged

test: use single testing-library/dom #5209

merged 2 commits into from
Nov 16, 2023

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Nov 15, 2023 •
edited
Loading

Done

  • use single testing-library/dom
    • update testing-library/cypress

This resolves most act errors that are caused by incorrect testing-library/dom resolution.
Prior to this PR we had 2 versions installed
This can be verified by using yarn why @testing-library/dom
More information: testing-library/user-event#906 (comment)

=> Found "@testing-library/dom@9.3.0"
info Reasons this module exists
   - "@testing-library#cypress" depends on it
   - Hoisted from "@testing-library#cypress#@testing-library#dom"
   - Hoisted from "@testing-library#react#@testing-library#dom"

QA steps

  • run yarn install and yarn why @testing-library/dom
  • verify that a single version of testing-library/dom is installed

Fixes

Fixes:

Screenshots

Notes

@webteam-app
Copy link

Demo starting at https://maas-ui-5209.demos.haus

@petermakowski petermakowski marked this pull request as ready for review November 15, 2023 13:45
@petermakowski petermakowski changed the title test: use single testing-library/dom test: use single testing-library/dom WIP Nov 15, 2023
@petermakowski petermakowski force-pushed the test-update-testing-library-dom branch from 970a367 to 28603a2 Compare November 16, 2023 15:36
@petermakowski petermakowski changed the title test: use single testing-library/dom WIP test: use single testing-library/dom Nov 16, 2023
@petermakowski petermakowski requested a review from ndv99 November 16, 2023 15:59
@ndv99
Copy link
Contributor

ndv99 commented Nov 16, 2023

Is this the output I should be expecting?
image

@petermakowski
Copy link
Contributor Author

Is this the output I should be expecting? image

Yes, different patch versions are expected. There was a bug in 9.3.0 that prevented tests from passing.

ndv99
ndv99 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski petermakowski merged commit 56c3913 into canonical:main Nov 16, 2023
6 checks passed
@petermakowski petermakowski deleted the test-update-testing-library-dom branch November 16, 2023 16:05
@ndv99 ndv99 mentioned this pull request Nov 16, 2023
Merged
9 tasks
ndv99 added a commit to ndv99/maas-ui that referenced this pull request Nov 16, 2023
@ndv99
Modify deps based on canonical#5209
945027c 
This should hopefully help me resolve the merge conflict
@petermakowski petermakowski restored the test-update-testing-library-dom branch May 9, 2024 10:21
@petermakowski petermakowski deleted the test-update-testing-library-dom branch May 9, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

Assignees
No one assigned
Labels
Maintenance 🔨 Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermakowski @webteam-app @ndv99