Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update canonicalwebteam.discourse to 5.5.0 #820

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Jun 25, 2024

Done

  • Update canonicalwebteam.discourse to 5.5.0. This adds functionality to remove trailing numbers from heading anchors, as by default they do not behave as expected

QA

@webteam-app
Copy link

Copy link

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petesfrench
Copy link
Contributor Author

@petermakowski Any idea why the CI is failing?

@petermakowski
Copy link
Contributor

@ndv99 Could you look into this please.

@ndv99
Copy link
Collaborator

ndv99 commented Jun 26, 2024

@ ndv99 Could you look into this please.

Yep!

@ndv99
Copy link
Collaborator

ndv99 commented Jun 26, 2024

Both run-dotrun and lint-python fail with the same error:

Error while fetching server API version: Not supported URL scheme http+docker

Seems to be caused by this bug: docker/docker-py#3256

Possible solutions:

  • Pin requests to <2.32, which isn't affected by this bug
  • Upgrade docker (python package) to >= 7.1.0, which contains a fix for this bug

I noticed however that docker isn't listed in the requirements file here, and I'm not quite sure where it inherits the version from (maybe dotrun?)

Use dotrun's pip version, and pin the requests version
Copy link
Collaborator

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @samhotep ! LGTM

@petesfrench petesfrench merged commit 9e989b0 into main Jun 27, 2024
7 checks passed
@petesfrench petesfrench deleted the petesfrench-patch-1 branch June 27, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants