-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add matrix-auth integration #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I have some comments/questions ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments/questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't finished the review. I have left some comments that may be applicable in the rest of the code. Let's discuss these initially, potentially update the rest of the code and then we can look at the rest
Test coverage for 52da8a6
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor comments
Applicable spec:
Overview
Add matrix-auth integration that allows integrate Maubot with Synapse.
Rationale
The first step to install a bot is create a client.
A client requires that the homeserver is configured in the Maubot configuration file.
Once is there, the user will run an action "register-client-account" that will create a user and return an access token and a device id.
See here for the entire flow:
https://docs.mau.fi/maubot/usage/basic.html#creating-clients
Extra:
Juju Events Changes
_on_matrix_auth_request_processed
Module Changes
Library Changes
Matrix auth library.
Checklist
src-docs
urgent
,trivial
,complex
)No CH available yet.