Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate with Prometheus and Grafana charms #18

Merged
merged 12 commits into from
Oct 15, 2024

Conversation

amandahla
Copy link
Collaborator

@amandahla amandahla commented Oct 9, 2024

Applicable spec:

Overview

Add integration between Maubot and Grafana/Prometheus.

Maubot does not provide a /metrics endpoints that Prometheus could read so Blackbox Prometheus Exporter was installed to collect data.

Why the trivial label? It's a large PR but nothing unusual.

Dashboard screenshot:

image

Rationale

Monitor Maubot application.

Juju Events Changes

Module Changes

Library Changes

Grafana and Prometheus libraries.

Checklist

No CH available

@amandahla amandahla requested a review from a team as a code owner October 9, 2024 19:35
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

Inclusive naming check

[Inclusive naming check] reported by reviewdog 🐶
[error] blackbox may be insensitive, use closed-box instead


[Inclusive naming check] reported by reviewdog 🐶
[error] Blackbox may be insensitive, use closed-box instead

"title": "Prometheus Maubot Blackbox Exporter",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 44 files.

Valid Invalid Ignored Fixed
11 1 32 0
Click to see the invalid file list
  • maubot_rock/blackbox.yaml
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

maubot_rock/blackbox.yaml Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 45 files.

Valid Invalid Ignored Fixed
11 2 32 0
Click to see the invalid file list
  • .woke.yaml
  • maubot_rock/blackbox.yaml
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

.woke.yaml Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
cbartz
cbartz previously approved these changes Oct 14, 2024
Copy link

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have some nit comments.

src/grafana_dashboards/maubot.json Show resolved Hide resolved
tests/integration/conftest.py Outdated Show resolved Hide resolved
Copy link

Test coverage for af9ca6e

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py     144     11     22      6    90%   137-139, 158, 162, 184, 188, 206, 233, 238, 263
----------------------------------------------------------
TOTAL            144     11     22      6    90%

Static code analysis report

Run started:2024-10-14 20:44:57.705981

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 668
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

renovate.json Show resolved Hide resolved
Copy link
Contributor

@merkata merkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@amandahla amandahla merged commit 9a69f0f into main Oct 15, 2024
17 checks passed
@amandahla amandahla deleted the ISD-2498-prometheus branch October 15, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants