-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate with Prometheus and Grafana charms #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 44 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
11 | 1 | 32 | 0 |
Click to see the invalid file list
- maubot_rock/blackbox.yaml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 45 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
11 | 2 | 32 | 0 |
Click to see the invalid file list
- .woke.yaml
- maubot_rock/blackbox.yaml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, have some nit comments.
Test coverage for af9ca6e
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Applicable spec:
Overview
Add integration between Maubot and Grafana/Prometheus.
Maubot does not provide a /metrics endpoints that Prometheus could read so Blackbox Prometheus Exporter was installed to collect data.
Why the trivial label? It's a large PR but nothing unusual.
Dashboard screenshot:
Rationale
Monitor Maubot application.
Juju Events Changes
Module Changes
Library Changes
Grafana and Prometheus libraries.
Checklist
src-docs
urgent
,trivial
,complex
)No CH available