snap: add support for kernel-gpu-2404 #20
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| .vscode |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| [package] | ||
| name = "component-monitor" | ||
| version = "0.1.0" | ||
| edition = "2021" | ||
|
|
||
| [dependencies] | ||
| clap = { version = "4", default-features = false, features = ["derive", "env", "help", "std", "usage"] } | ||
| exitcode = { version = "1", default-features = false } | ||
|
There was a problem hiding this comment. I think this dependency can be safely dropped, it looks like it's just being used to get |
||
| log = { version = "0.4", default-features = false } | ||
| nix = { version = "0.29", default-features = false, features = ["inotify"] } | ||
| signal-hook = { version = "0.3", default-features = false, features = ["iterator"] } | ||
| systemd-journal-logger = { version = "2", default-features = false } | ||
| walkdir = { version = "2", default-features = false } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little surprised that the
color,error-contextandsuggestionsfeatures are absent, is this for compatibility? Personally I'm a sucker for pretty terminal applications :D (have you also considered thewrap_helpfeature?) I see the rest of the dependencies deliberately don't have their default features enabled so I suspect this is all intentionalThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really it's just for keeping it tight. It's not really a CLI application, just an internal service.
I dropped
default_featuresacross the board b/c I dislike things creeping up on me, is all ;)And Innes warned me about
nixbeing heavy, so that's probably why ;)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this sounds really good, thanks for the clarification!