Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: Fix doc build. #100

Merged
merged 1 commit into from
Nov 24, 2023
Merged

snap: Fix doc build. #100

merged 1 commit into from
Nov 24, 2023

Conversation

fnordahl
Copy link
Member

On non-x86/arm64 architectures the doc build currently fails due to prebuilt python wheels not being available.

Add the missing build dependencies.

Use the python3-venv metapackage instead of specifying the specific version.

On non-x86/arm64 architectures the doc build currently fails due
to prebuilt python wheels not being available.

Add the missing build dependencies.

Use the `python3-venv` metapackage instead of specifying the
specific version.

Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>
@fnordahl fnordahl requested a review from a team as a code owner November 24, 2023 07:15
Copy link
Contributor

@mkalcok mkalcok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Side note: Maybe we should try running build test on all supported topologies. Although I have no idea if we have such runners available

@fnordahl
Copy link
Member Author

Makes sense to me.

Side note: Maybe we should try running build test on all supported topologies. Although I have no idea if we have such runners available

Indeed we should find some way to test on all architectures.

Even though we are using self-hosted runners I believe we are currently blocked by the lack of architecture support in the GitHub Actions runner itself ref actions/runner#2263 and actions/runner#2365.

@fnordahl fnordahl merged commit 187217d into canonical:main Nov 24, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants