Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused mysql relation #75

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Apr 8, 2024

The charm has a mysql relation that is not used as it is provided by the mariadb charm which is no longer supported. The other alternative is to use the relational-db relation to relate to mysql-k8s charm, but due to #64, it is not possible.

In #71 it was decided that instead of an external DB provider, the mlmd charm will use the SQLite implementation it has been using for a while. In PR#72 the charm code has been modified to exclusively use SQLite.

Fixes #73

The charm has a mysql relation that is not used as it is provided by the mariadb charm which is no longer supported.
The other alternative is to use the relational-db relation to relate to mysql-k8s charm, but due to #64, it is not possible.

In #71 it was decided that instead of an external DB provider, the mlmd charm will use the SQLite implementation it has been using for a while.
In PR#72 the charm code has been modified to exclusively use SQLite.

Fixes #73
@DnPlas DnPlas requested a review from a team as a code owner April 8, 2024 11:22
@DnPlas DnPlas merged commit 57d4953 into main Jun 21, 2024
7 checks passed
@DnPlas DnPlas deleted the KF-5484-remove-unused-mysql-relation branch June 21, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused mysql relation
2 participants