[DPE-3314] remove secrets on broken #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
commented
Jan 15, 2024
MiaAltieri
force-pushed
the
remove-relation-data
branch
from
5ed42b8
to
ded8407
Compare
dmitry-ratushnyy
approved these changes
Jan 16, 2024
Mehdi-Bendriss
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI
most of the work here is done on the
mongosside, but some changes are needed in the libs that are owned by this charmIssue
Secretes associated with username, password, uri are still present on the
host-applicationandmongos sub-charmrelation after relation withconfig-serverandmongos sub-charmis brokenSolution
Call appropriate functions from mongos charm
Future PRs