Use relation_created instead of relation_joined
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever and
shayancanonical
shayancanonical
approved these changes
Jun 28, 2023
paulomach
approved these changes
Jun 29, 2023
taurus-forever
approved these changes
Jun 30, 2023
| @@ -409,6 +409,25 @@ def unhold(self) -> None: | |||
| """Remove the refresh hold of a snap.""" | |||
| self._snap("refresh", ["--unhold"]) | |||
|
|
|||
| def alias(self, application: str, alias: Optional[str] = None) -> None: | |||
There was a problem hiding this comment.
AFAIK, the library now has been improved. No need to call subprocess. CC: @dragomirp , right?
There was a problem hiding this comment.
This is the latest version of the lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from canonical/mysql-router-k8s-operator#101