Pin python dependencies with Poetry #60
Conversation
carlcsaposs-canonical
force-pushed
the
poetry
branch
from
c1a8bc8
to
d467692
Compare
carlcsaposs-canonical
force-pushed
the
poetry
branch
from
efd5593
to
29576f4
Compare
carlcsaposs-canonical
force-pushed
the
poetry
branch
from
5941574
to
eff6b1c
Compare
|
Depends on canonical/data-platform-workflows#80 |
|
Note that tls and shared db integration tests were disabled before this PR |
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever and
shayancanonical
| get_count_keystone_tables_sql, | ||
| ) | ||
| assert output[0] > 0 | ||
| # TODO: re-enable when bug resolved: https://bugs.launchpad.net/charm-keystone/+bug/1990243 |
There was a problem hiding this comment.
i am unsure if commenting these tests is ideal - i would rather they be deleted if they are not running or mark them unstable. is there any reason they're being commented instead?
There was a problem hiding this comment.
I don't think they're unstable—just broken
The unstable mark runs the tests nightly
In order to maintain the same behavior in the repo as before the PR, the tests need to be commented out so a runner isn't provisioned in the collect_groups step (I previously added pytest.mark.skip(), but it provisioned a runner)
Should we delete them then?
There was a problem hiding this comment.
I would be in favor of deleting them. Thoughts @paulomach?
There was a problem hiding this comment.
Q: https://bugs.launchpad.net/charm-keystone/+bug/1990243 is marked as "Will not fix" (as already fixed in another library). If the test is still broken, we need to reopen the ticket, otherwise re-enable the test. Isn't it?
There was a problem hiding this comment.
I'd prefer for that to be a separate ticket since the test was already disabled. For now, should I delete or leave commented out?
| get_count_keystone_tables_sql, | ||
| ) | ||
| assert output[0] > 0 | ||
| # TODO: re-enable when bug resolved: https://bugs.launchpad.net/charm-keystone/+bug/1990243 |
There was a problem hiding this comment.
Q: https://bugs.launchpad.net/charm-keystone/+bug/1990243 is marked as "Will not fix" (as already fixed in another library). If the test is still broken, we need to reopen the ticket, otherwise re-enable the test. Isn't it?
carlcsaposs-canonical
force-pushed
the
poetry
branch
from
414694a
to
7327501
Compare
Ported from canonical/mysql-k8s-operator#273