Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update expected Pebble plan when using ops 2.10+ #57

Closed

Conversation

tonyandrewmeyer
Copy link

@tonyandrewmeyer tonyandrewmeyer commented Feb 12, 2024


Issue

From ops 2.10, Harness includes the checks in the returned Pebble plan (as is the case in production when actually using Pebble). This means that the unit tests fail against ops 2.10+.

Solution

Adjust the expected plan in the unit test to match the one that is returned both (now) in production and in testing.

Additional context

I've also bumped the pinned version to be 2.10+ onwards - otherwise the tests should technically handle both cases since the dependency constraint could be satisfied by an older version. Since 2.10 was accepted previously, I'm assuming that this is otherwise ok. There are also some versions after 2.0 (the previous pinned version) where the tests don't pass for other reasons, so I think that it wasn't actually compatible going back that far any more.

Testing Instructions

Run tests against ops 2.9 and 2.10.

Release Notes

Fixes tests to run under ops 2.10+.

@tonyandrewmeyer tonyandrewmeyer requested a review from a team as a code owner February 12, 2024 21:59
@natalian98
Copy link
Contributor

Hi @tonyandrewmeyer, thanks a lot for opening the PR and providing the context around it.

I will close this PR as the change was already addressed in #56 (see tests).

@natalian98 natalian98 closed this Feb 13, 2024
@tonyandrewmeyer tonyandrewmeyer deleted the include-check-in-plan branch February 13, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants