Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support user email and name custom headers #58

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

natalian98
Copy link
Contributor

This PR adds support for new custom headers: X-Name and X-Email. They are mapped with kratos identity.traits claims.

@natalian98 natalian98 marked this pull request as ready for review February 14, 2024 15:16
@natalian98 natalian98 requested a review from a team as a code owner February 14, 2024 15:16
Copy link
Contributor

@shipperizer shipperizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we not allowing completely custom headers via a config parameter in the charm?

this works, but the headers are vetted by us instead of being fully custom

@natalian98
Copy link
Contributor Author

natalian98 commented Feb 14, 2024

why are we not allowing completely custom headers via a config parameter in the charm?

this works, but the headers are vetted by us instead of being fully custom

If this was a config option, the end user wouldn't necessarily know how to map the the headers with kratos claims.

You can specify which ones should be returned with the headers parameter (see here)

@natalian98 natalian98 requested a review from a team February 14, 2024 16:52
@natalian98 natalian98 merged commit 62f2106 into main Feb 16, 2024
3 checks passed
@natalian98 natalian98 deleted the IAM-679-add-custom-headers branch February 16, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants