Skip to content

Commit

Permalink
fix: final adjustments and docs
Browse files Browse the repository at this point in the history
  • Loading branch information
clay-lake committed Feb 6, 2025
1 parent bb6a168 commit f07a1de
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/Build-Rock.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ on:
secrets:
# authentication parameters
host-github-token:
description: "Github token for operating in private repositories"
description: "Github token for operating in a private repository."
source-github-token:
description: "Github token for pulling from private repositories"
description: "Github token for pulling from private repositories."
env:
ROCK_REPO_DIR: rock-repo # path where the image repo is cloned into
ROCK_CI_FOLDER: ci-rocks # path of uploaded/downloaded artifacts
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Test-Rock.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ on:
secrets:
# authentication parameters
host-github-token:
description: "Github token for operating in private repositories"
description: "Github token for operating in a private repository."

env:
VULNERABILITY_REPORT_SUFFIX: ".vulnerability-report.json" # TODO: inherit string from caller
Expand Down
11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,12 @@ supported through Launchpad build services.
| `arch-map` | False | JSON str | JSON string mapping target architecture to runners. |
| `lpci-fallback` | False | bool | Enable fallback to Launchpad build when runners for target arch are not available. |

**Workflow Secrets:**
| Property | Required | Description |
|---|---|---|
| `source-github-token` | False | Github token for pulling from private repositories.|
| `host-github-token` | False | Github token for operating in a private repository. |

### Test-Rock Workflow

The [Test-Rock workflow](.github/workflows/Test-Rock.yaml)
Expand Down Expand Up @@ -458,3 +464,8 @@ needed.
|`test-vulnerabilities`| False | bool | Enable Trivy vulnerability test. Enabled by default. |
|`trivyignore-path`| False | str | Optional path to `.trivyignore` file used in vulnerability scan. |
|`test-malware`| False | bool | Enable ClamAV malware test. Enabled by default. |

**Workflow Secrets:**
| Property | Required | Description |
|---|---|---|
| `host-github-token` | False | Github token for operating in a private repository.|

0 comments on commit f07a1de

Please sign in to comment.