Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oidc-gatekeeper only works with Dex as OIDC provider and Charmed Kubeflow #159

Closed
DnPlas opened this issue Jul 5, 2024 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Jul 5, 2024

Context

While the OIDC Authservie is an application that can work essentially with any OIDC provider, the oidc-gatekeeper charm that tries to model it was originally designed around Dex and Kubeflow; this can be concluded by looking at the env variables in the code.

Because of that and after chatting with @kimwnasptd, it was decided that although this charm could be re-designed to work with any OIDC provider (Dex included), this team will not work on that and will keep it as it is, limiting its capabilities for Charmed Kubeflow exclusively.

What needs to get done

Update the README to specify this charm will not work outside of an environment without Dex and Charmed Kubeflow and that it cannot be used by any other application when in need of an OIDC client.

Definition of Done

The README contains clear information about what this charm can and cannot do and how it should be deployed.

@DnPlas DnPlas added the enhancement New feature or request label Jul 5, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5971.

This message was autogenerated

DnPlas added a commit that referenced this issue Jul 25, 2024
Add a section describing how this charm can only be used as an OIDC client when Dex and
Charmed Kubeflow are deployed in the model; otherwise it will fail, as there are multiple
parts of this charm's code that are tightly coupled to those.

Fixes #159
DnPlas added a commit that referenced this issue Jul 26, 2024
Add a section describing how this charm can only be used as an OIDC client when Dex and
Charmed Kubeflow are deployed in the model; otherwise it will fail, as there are multiple
parts of this charm's code that are tightly coupled to those.

Fixes #159
@DnPlas
Copy link
Contributor Author

DnPlas commented Jul 26, 2024

Fixed by #166

@DnPlas DnPlas closed this as completed Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant