feat: add OIDC_AUTH_URL and AFTER_LOGIN_URL env variables #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DnPlas
force-pushed
the
KF-5375-add-env-variable
branch
from
93726f7 to
be99aee
Compare
These variables are required by the OIDC Authservice to correctly redirect users along the authentication flow. * OIDC_AUTH_URL: is used as the URL tht Authservice will hit for initiating the auth flow * AFTER_LOGIN_URL: is used for redirecting after login These variables are required because the default behaviour of OIDC Authservice is to redirect to URLs that can be undesired, by setting them up, we have a deterministic way of setting where users should be redirected. Part of canonical/bundle-kubeflow#608
DnPlas
force-pushed
the
KF-5375-add-env-variable
branch
from
be99aee to
ddc32e5
Compare
kimwnasptd
approved these changes
Feb 26, 2024
DnPlas
added a commit
that referenced
this pull request
Feb 26, 2024
* feat: add OIDC_AUTH_URL and AFTER_LOGIN_URL env variables These variables are required by the OIDC Authservice to correctly redirect users along the authentication flow. * OIDC_AUTH_URL: is used as the URL tht Authservice will hit for initiating the auth flow * AFTER_LOGIN_URL: is used for redirecting after login * AFTER_LOGOUT_URL: is used for redirecting after logout. These variables are required because the default behaviour of OIDC Authservice is to redirect to URLs that can be undesired, by setting them up, we have a deterministic way of setting where users should be redirected. Part of canonical/bundle-kubeflow#608
DnPlas
added a commit
that referenced
this pull request
Feb 26, 2024
feat: add OIDC_AUTH_URL and AFTER_LOGIN_URL env variables (#136)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These variables are required by the OIDC Authservice to correctly redirect users along the authentication flow.
These variables are required because the default behaviour of OIDC Authservice is to redirect to URLs that can be undesired, by setting them up, we have a deterministic way of setting where users should be redirected.
Part of canonical/bundle-kubeflow#608