Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scripts #77

Merged
merged 7 commits into from
Nov 20, 2023
Merged

Remove scripts #77

merged 7 commits into from
Nov 20, 2023

Conversation

PietroPasotti
Copy link
Collaborator

@PietroPasotti PietroPasotti commented Nov 15, 2023

This PR removes the scripts shipped with scenario. In the future people will have to install jhack to use them.
Fixes #75

Jhack: canonical/jhack#111

Copy link
Collaborator

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I didn't verify that the corresponding jhack pull matches, but I assume you've handled that.

pyproject.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Tony's comment about the patch version, but LGTM.

@PietroPasotti PietroPasotti merged commit 7a4e2cb into main Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move the scripts to jhack
3 participants