Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-4617] Add support for tracing with tempo_k8s #497

Merged
merged 11 commits into from
Jun 25, 2024

Conversation

shayancanonical
Copy link
Contributor

Issue

We would like to be able to instrument our charm and generate traces to discover inefficiencies in charm code execution. The observability team has developed a charm for tempo that we would like to integrate with.

Solution

Integrate with the tempo charm

Considerations

  1. We must use COS lite with edge until it is release to stable with some critical changes
  2. We are sending traces with HTTP until some rough edges are rounded with HTTPS

image

lib/charms/tempo_k8s/v1/charm_tracing.py Dismissed Show dismissed Hide dismissed
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx!

@shayancanonical shayancanonical changed the title Add support for tracing with tempo_k8s [DPE-4617] Add support for tracing with tempo_k8s Jun 12, 2024
@marceloneppel
Copy link
Member

Hi, @shayancanonical! Most of the errors in the async replication tests should be fixed by #526. It was not moved to review yet because another issue happened today when running on CI.

Also, the update in the lib/charms/observability_libs/v1/kubernetes_service_patch.py library is breaking the async replication tests due to canonical/observability-libs#101.

To merge this PR, you can revert the lib/charms/observability_libs/v1/kubernetes_service_patch.py update. After a few retries, the async replication tests should pass.

@shayancanonical
Copy link
Contributor Author

thanks for helping investigate the root cause of the failing test @marceloneppel. i will momentarily revert the charm lib and update this PR

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.23%. Comparing base (212f2c8) to head (bbf9a36).

Files Patch % Lines
src/charm.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
+ Coverage   70.19%   70.23%   +0.03%     
==========================================
  Files          10       10              
  Lines        2775     2785      +10     
  Branches      516      518       +2     
==========================================
+ Hits         1948     1956       +8     
- Misses        729      731       +2     
  Partials       98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shayancanonical shayancanonical merged commit bad961d into main Jun 25, 2024
52 checks passed
@shayancanonical shayancanonical deleted the feature/tempo_tracing branch June 25, 2024 13:24
@marceloneppel marceloneppel restored the feature/tempo_tracing branch June 26, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants