-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-5311] Enable DCS failsafe mode #677
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
=======================================
Coverage 70.71% 70.71%
=======================================
Files 11 11
Lines 2950 2950
Branches 513 513
=======================================
Hits 2086 2086
Misses 754 754
Partials 110 110 ☔ View full report in Codecov by Sentry. |
@7annaba3l we are pending your ACK to merge this. I believe we should enable failsafe, @delgod had doubts about the split brain but manuals says it is safe:
4 @dragomirp : I want to merge this and fix #669 and #616. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after careful check of implementation details - everything looks safe (even in upgrade case) and I believe we should enable this option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mykola approved, Mohamed notified in MM. LGTM from me. Thank you!
Issue
Patroni depends on the K8s API and resources to maintain the leader lock. Primary will step down during a temporary K8s API outage
Solution
Enable DCS failsafe mode. If the K8s API (DCS) is not available, Patroni will try to maintain the current primary if it can connect to all cluster members
Documentation: https://patroni.readthedocs.io/en/latest/dcs_failsafe_mode.html#dcs-failsafe-mode
Related #669 and #616