[DPE-5165] Add log for fix_leader_annotation method #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
marceloneppel
requested review from
taurus-forever,
dragomirp and
lucasgameiroborges
lucasgameiroborges
approved these changes
Sep 4, 2024
dragomirp
approved these changes
Sep 4, 2024
It already appears in the log before the logged messages. It will show something like: unit-postgresql-k8s-0: 20:42:27 INFO unit.postgresql-k8s/0.juju-log Fixed missing leader annotation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We don't know all the moments when the
leaderannotation is fixed (we know that one situation - expected - is after a scale down to 0 units and then a scale up to 1 unit), which causes thecluster_initialisedflag to be removed from the peer relation data (this is causing issues in production like the one reported at #634).Solution
Add a log for the
fix_leader_annotationmethod so we can better understand why the issue occurs.