Add missing snap build dependencies #132
Merged
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxml is a python dependency of a dependency.
On arm64 and amd64, pip can install the binary wheel,
but these binary wheels aren't available for other architectures.
For them, currently the build fails with:
```
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [4 lines of output]
<string>:67: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
Building lxml version 5.2.2.
Building without Cython.
Error: Please make sure the libxml2 and libxslt development packages are installed.
[end of output]
```
So the required build dependencies must be added to the snap definition.
samuelallan72
requested review from
a team,
Pjack,
aieri,
jneo8,
gabrielcocenza,
rgildein and
chanchiwai-ray
Binary wheels for the cffi python package aren't available on some
architectures, so we need to add dependencies so pip can build it
from source.
Fixes the following error during snap build:
```
src/c/_cffi_backend.c:15:10: fatal error: ffi.h: No such file or directory
15 | #include <ffi.h>
| ^~~~~~~
compilation terminated.
error: command '/usr/bin/arm-linux-gnueabihf-gcc' failed with exit code 1
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for cffi
```
samuelallan72
changed the title
|
Note: I'm testing builds on other architectures with |
Binary wheels for the cryptography python package aren't available on some architectures, so we need to add dependencies so pip can build it from source.
|
Can confirm successful build on all supported architectures with this patch: |
jneo8
approved these changes
Jun 14, 2024
Pjack
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some architectures, binary wheels for some pypi packages aren't available, so pip must build them from source. Some of these require more build dependencies that must be installed:
lxmlrequireslibxml2-devandlibxslt1-devcffirequireslibffi-devcryptographyrequiresrustc,cargo,libssl-dev,pkg-config