tox: bump pylint to 2.12.2 #173
Merged
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a E1136 false positive with Python 3.9 [1], but the code needs some changes to test clean. [1] pylint-dev/pylint#3882
|
Let me know if you prefer me to batch-fix C0209 (consider-using-f-string) instead of silencing it. |
TheRealFalcon
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
I would like us to upgrade all of our string formatting to f-strings eventually. They're faster and cleaner than the other formatting options. I'm also aware of a tool that should make it easier when we do decide to do it.
This can (and probably should) be a separate PR though, so this PR Is good as-is.
|
https://github.com/ikamensh/flynt: nice! But I gave it a blind shot and it didn't detect/convert 100% of the format strings (a number of C0209 remain for some reason), and there are some "E501 line too long" to fix. Maybe worth a separate PR as you say. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a E1136 false positive with Python 3.9 [1], but the code
needs some changes to test clean.
[1] pylint-dev/pylint#3882