Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update containers.rst #294

Closed
wants to merge 1 commit into from
Closed

Conversation

ilyakimavets
Copy link
Contributor

Add set up config in creating container. And fix mistake in container save method

@ajkavanagh
Copy link
Contributor

Hi @ilyakimavets, thanks for the PR. However, due to the new policy github lxc organisation, all commits need a 'signed off' line. (see the DCO fail above).

The easiest way to do this is (in your git branch with your recent commit):

git commit -s --amend --no-edit
git push <your remote> -f

The '-f' just force updates the commit and the PR will be updated. The DCO check above will then be satisfied.

Thanks very much, and sorry for the small annoyance on commits here.

@ajkavanagh
Copy link
Contributor

Hi @ilyakimavets, please could you rebase your PR as it's now got conflicts with the base. Thanks very much!

Copy link
Contributor

@ajkavanagh ajkavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebasing please.

@ajkavanagh
Copy link
Contributor

I've rebased this and merged it via #385.

@ajkavanagh ajkavanagh closed this Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants