Removed credentials from set_result event handlers #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welpaolo
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
LGMT. Please @taurus-forever check if the current output messages are fine with you.
taurus-forever
approved these changes
Jan 29, 2024
| @@ -42,7 +42,9 @@ jobs: | |||
|
|
|||
| build: | |||
| name: Build charms | |||
| uses: canonical/data-platform-workflows/.github/workflows/build_charms_with_cache.yaml@v2 | |||
| uses: canonical/data-platform-workflows/.github/workflows/build_charms_with_cache.yaml@v8.0.0 | |||
There was a problem hiding this comment.
We have already version 11 of shared workflows... but we need to have here renovate anyway... will be updated later. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Credentials get printed to the terminal in plaintext when using s3-integrator. This causes a security issue during demos and video recordings.
(see DPE-3198 for more details)
Solution
Update event handlers/observers that print the credentials.
_on_sync_s3_credentials()will instead display a message related to the action (e.g. "Credentials successfully updated")on_get_connection_info_action()will replace the secrets with asterisks.