Skip to content

Commit

Permalink
fix: removed not supported static image (#186)
Browse files Browse the repository at this point in the history
#197

`seldonio/egine` image was removed from the project: SeldonIO/seldon-core@6fc7f9b

There is no need to keep this image in static list of image retrieval script.

Summary of changes:
- Removed seldonio/egine image from the static list (and the whole static list, because it is empty now).
  • Loading branch information
i-chvets authored Aug 31, 2023
1 parent 45f7ccb commit 3965078
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions tools/get-images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@
#
# This script returns list of container images that are managed by this charm and/or its workload
#
# static list
STATIC_IMAGE_LIST=(
# from seldon-core
docker.io/seldonio/engine:1.12.0
)
# dynamic list
IMAGE_LIST=()
IMAGE_LIST+=($(find $REPO -type f -name metadata.yaml -exec yq '.resources | to_entries | .[] | .value | ."upstream-source"' {} \;))
Expand All @@ -17,5 +12,4 @@ IMAGE_LIST+=($(yq '.options | ."executor-container-image-and-version" | .default
IMAGE_LIST+=($(yq e ".data.storageInitializer" src/templates/configmap.yaml.j2 | jq -r 'select((.image)) | "\(.image)"'))
IMAGE_LIST+=($(yq e ".data.explainer" src/templates/configmap.yaml.j2 | jq -r 'select((.image)) | "\(.image)"'))
IMAGE_LIST+=($(yq e ".data.explainer" src/templates/configmap.yaml.j2 | jq -r 'select((.image_v2)) | "\(.image_v2)"'))
printf "%s\n" "${STATIC_IMAGE_LIST[@]}"
printf "%s\n" "${IMAGE_LIST[@]}"

0 comments on commit 3965078

Please sign in to comment.