Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging relation to seldon-core #259

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Add logging relation to seldon-core #259

merged 2 commits into from
Jul 11, 2024

Conversation

rgildein
Copy link
Contributor

Use LogForwarder from loki_push_api library to forwards all logs from workload container to Loki. This requires to use ops 2.9 or newer, so it was needed to be updated.

fixes: #253

How I tested it:

# deployed the cos following https://charmhub.io/topics/canonical-observability-stack/tutorials/install-microk8s
$ tox -e integration -- --keep-models
$ juju switch test-charm-3uzf
u1-k8s:admin/test-charm-aosq -> u1-k8s:admin/test-charm-3uzf
# we need redeploy charm, since there is test that is removing it
$ charmcraft pack
Created 'seldon-core_ubuntu-20.04-amd64.charm'.                                                 
Charms packed:
    seldon-core_ubuntu-20.04-amd64.charm
$ juju deploy ./seldon-core_ubuntu-20.04-amd64.charm --resource oci-image=charmedkubeflow/seldon-core-operator:1.17.1-c95840c
Located local charm "seldon-core", revision 0
Deploying "seldon-core" from local charm "seldon-core", revision 0 on ubuntu@20.04/stable
$ juju integrate istio-pilot:gateway-info seldon-core:gateway-info
$ juju consume u1-k8s:cos.loki-logging 
Added u1-k8s:admin/cos.loki-logging as loki-logging
$ juju integrate grafana-agent-k8s loki-logging
$ juju integrate seldon-core:logging grafana-agent-k8s
...

And after checking the Grafana, I was able to see all logs.
Screenshot from 2024-07-10 12-37-34

@rgildein
Add logging relation to seldon-core
fa1f6af 
Use LogForwarder from loki_push_api library to forwards all logs from
workload container to Loki. This requires to use ops 2.9 or newer, so it
was needed to be updated.

fixes: #253
@rgildein rgildein added the enhancement New feature or request label Jul 10, 2024
@rgildein rgildein self-assigned this Jul 10, 2024
@rgildein rgildein requested a review from a team as a code owner July 10, 2024 10:37
@rgildein
bump all integration requirements
3716ad5 
We are testing on Juju 3.5, but we use libjuju 3.2.2. This version do
not support websockets 12.0, however on my system I reqire to have
at-least 10.0.
@rgildein rgildein merged commit 45aec2c into main Jul 11, 2024
17 checks passed
@rgildein rgildein deleted the feat/KF-5803/log-forwarding branch July 11, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orfeas-k orfeas-k orfeas-k approved these changes

Assignees

@rgildein rgildein

Labels
enhancement New feature or request Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add logging relation to seldon-core charm
2 participants
@rgildein @orfeas-k