Update tls_certificates_interface lib to fix permission deny error during scale operation #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saltiyazan
reviewed
Sep 12, 2023
|
Waiting PR canonical/tls-certificates-interface#70 in the tls-certificates-library to be merged. |
gatici
force-pushed
the
TELCO-734-Scale-up-operation-should-not-crash
branch
2 times, most recently
from
f82878d to
cb7e4f8
Compare
gatici
changed the title
gatici
force-pushed
the
TELCO-734-Scale-up-operation-should-not-crash
branch
2 times, most recently
from
809b532 to
64965e4
Compare
…ring scale operation Signed-off-by: gatici <gulsum.atici@canonical.com>
gatici
force-pushed
the
TELCO-734-Scale-up-operation-should-not-crash
branch
from
64965e4 to
803a03c
Compare
gatici
force-pushed
the
TELCO-734-Scale-up-operation-should-not-crash
branch
from
9151a18 to
7cb361e
Compare
Gmerold
reviewed
Sep 19, 2023
|
Please update the PR description :) |
Signed-off-by: gatici <gulsum.atici@canonical.com>
gatici
force-pushed
the
TELCO-734-Scale-up-operation-should-not-crash
branch
from
7cb361e to
8703f6f
Compare
Done |
saltiyazan
approved these changes
Sep 20, 2023
patriciareinoso
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix #24 by bumping the library version to include the fix and it also adds tests for validation. Scale up operation does not crash the charm, after scaling a non-leader unit in this charm doesn't do anything.
Checklist: