feat(lint): migrate lint command

snapcraft/application.py

@@ -158,6 +158,10 @@ def _get_dispatcher(self) -> craft_cli.Dispatcher:
         # project's base (if any). Here, we handle the case where there *is*
         # a project and it's core24, which means it should definitely fall into
         # the craft-application-based flow.
+        if "lint" in sys.argv:
+            # We don't need to check for core24 if we're just linting
+            return super()._get_dispatcher()
+
         if self._snapcraft_yaml_path:
             with self._snapcraft_yaml_path.open() as file:
                 yaml_data = util.safe_yaml_load(file)
@@ -280,7 +284,7 @@ def create_app() -> Snapcraft:
         "Other",
         list(craft_app_commands.get_other_command_group().commands)
         + [
-            unimplemented.Lint,
+            commands.LintCommand,
             unimplemented.Init,
         ],
     )

snapcraft/cli.py

@@ -121,7 +121,6 @@
     craft_cli.CommandGroup(
         "Other",
         [
-            commands.core22.LintCommand,
             commands.core22.InitCommand,
         ],
     ),

snapcraft/commands/__init__.py

@@ -38,6 +38,7 @@
     StoreLegacyValidateCommand,
 )
 from .lifecycle import SnapCommand
+from .lint import LintCommand
 from .manage import StoreCloseCommand, StoreReleaseCommand
 from .names import (
     StoreLegacyListCommand,
@@ -58,6 +59,7 @@
 
 __all__ = [
     "ExpandExtensions",
+    "LintCommand",
     "ListExtensions",
     "RemoteBuildCommand",
     "SnapCommand",

snapcraft/commands/core22/__init__.py

@@ -33,7 +33,6 @@
     StageCommand,
     TryCommand,
 )
-from .lint import LintCommand
 from .remote import RemoteBuildCommand
 
 __all__ = [
@@ -42,7 +41,6 @@
     "ExpandExtensionsCommand",
     "ExtensionsCommand",
     "InitCommand",
-    "LintCommand",
     "ListExtensionsCommand",
     "ListPluginsCommand",
     "PackCommand",

snapcraft/commands/core22/lint.py → snapcraft/commands/lint.py

@@ -1,6 +1,6 @@
 # -*- Mode:Python; indent-tabs-mode:nil; tab-width:4 -*-
 #
-# Copyright 2023 Canonical Ltd.
+# Copyright 2023-2024 Canonical Ltd.
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
@@ -24,9 +24,10 @@
 import textwrap
 from contextlib import contextmanager
 from pathlib import Path, PurePosixPath
-from typing import Iterator, Optional
+from typing import Any, Iterator, Optional
 
-from craft_cli import BaseCommand, emit
+from craft_application.commands import ExtensibleCommand
+from craft_cli import emit
 from craft_cli.errors import ArgumentParsingError
 from craft_providers.multipass import MultipassProvider
 from craft_providers.util import snap_cmd
@@ -42,9 +43,10 @@
 )
 
 
-class LintCommand(BaseCommand):
+class LintCommand(ExtensibleCommand):
     """Lint-related commands."""
 
+    always_load_project = False
     name = "lint"
     help_msg = "Lint a snap file"
     overview = textwrap.dedent(
@@ -58,7 +60,7 @@ class LintCommand(BaseCommand):
     )
 
     @overrides
-    def fill_parser(self, parser: "argparse.ArgumentParser") -> None:
+    def _fill_parser(self, parser: argparse.ArgumentParser) -> None:
         parser.add_argument(
             "snap_file",
             metavar="snap-file",
@@ -78,8 +80,7 @@ def fill_parser(self, parser: "argparse.ArgumentParser") -> None:
             help="Set https proxy",
         )
 
-    @overrides
-    def run(self, parsed_args: argparse.Namespace):
+    def _run(self, parsed_args: argparse.Namespace, **kwargs: Any) -> None:
         """Run the linter command.
 
         :param parsed_args: snapcraft's argument namespace

snapcraft/commands/unimplemented.py

@@ -105,9 +105,3 @@ class Try(
     UnimplementedMixin, commands.core22.TryCommand
 ):  # noqa: D101 (missing docstring)
     pass
-
-
-class Lint(
-    UnimplementedMixin, commands.core22.LintCommand
-):  # noqa: D101 (missing docstring)
-    pass

tests/spread/core24/linters-file/task.yaml

@@ -1,6 +1,4 @@
 summary: Run snapcraft lint on a snap file.
-# Disabled from regular CI runs until we have "snapcraft lint" in core24
-manual: true
 
 environment:
   SNAP: lint-file