-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate installed_base_by_architecture metrics #4735
Activate installed_base_by_architecture metrics #4735
Conversation
I signed the CLA last night with the email address on my Snapcraft account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thanks for the contribution!
PS - I just added these to this documentation page |
Thank you very much :)
Thank you, that's great! |
@mr-cal How should we proceed with regard to the failing CLA check? I have signed it with both the email address on the commit and the email address on my Launchpad account. |
It looks like this problem with the github action: canonical/has-signed-canonical-cla#37. @sergiusens - How should we proceed? |
The 404 is a result of the query. This should be fine to merge in anyways without waiting. but we can retry later and if it does not work I can go and track the systems responsible for the data. |
Thank you both |
@mr-cal @sergiusens Do you need me to do/confirm anything? |
@sergiusens - Can you override and merge? |
Pursuant to my post on Discourse (https://forum.snapcraft.io/t/enable-by-architecture-in-the-snapcraft-metrics-cli-tooling/39750), this commit activates the installed_base_by_architecture and weekly_installed_base_by_architecture metrics in the snapcraft metrics tool. The metric was previously introduced according to this PR canonical/snapcraft.io#1680 (comment) A subsequent issue will be raised against the documentation.
5de27cf
to
ada09ba
Compare
I'll get this landed on Friday or early next week, after we ship snapcraft 8.2.1. |
Thank you |
Override-merging because CLA has been signed. |
Pursuant to my post on Discourse
(https://forum.snapcraft.io/t/enable-by-architecture-in-the-snapcraft-metrics-cli-tooling/39750), this commit activates the installed_base_by_architecture and weekly_installed_base_by_architecture metrics in the snapcraft metrics tool.
The metric was previously introduced according to this PR canonical/snapcraft.io#1680 (comment)
A subsequent issue will be raised against the documentation.
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)