-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sgmoore/fix qtwebengineprocess #4745
Sgmoore/fix qtwebengineprocess #4745
Conversation
Fixed linter tests.
Fix the target for kf6 to point to its own dir kf6. Fix test accordingly.
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Remove the qt6 platform plug as we bundle the qt6 in the kf6 runtime due to limited to one platform plug.
Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Co-authored-by: Michał Sawicz <michal@sawicz.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy to test this if I could install a corresponding snap.
I installed snapcraft from pull request Spread Tests artifact (https://github.com/canonical/snapcraft/actions/runs/8740342524), and used it to build a snap that used QtWebEngine. It worked properly. thanks. I did see the following messages with the snap based gpsbabelfe, BUT I ALSO see these when I build directly on jammy with Qt 6.7.0, so these messages are NOT specific to the snap build.
|
With the latest snap (from https://github.com/canonical/snapcraft/actions/runs/8740342524) I have verified that translations work. They work because of the layout mapping /usr/share/qt6 -> $SNAP/kf6/usr/share/qt6, .i.e. my snap successfully finds translations via the /usr/share/qt6 path. I have verified no qt.conf is created in ~/snap/gpsbabel/. The QtWebEngine part of my app works as well. FYI my snapcraft.yaml file is https://github.com/tsteven4/gpsbabel/blob/5935f437a8a996057a996f7316e614578e92fe20/snap/snapcraft.yaml 👏 👏 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! All looks good to me, and ark
and kcalc
are still building & working as expected
I do have issues running a snapped app with QtWebEngine on Linux if apparmor is enforcing. Chromium is trying to access /dev/shm. I can solve this by adding the shared-mem plug in private mode to my snap. Is the proper place to do this in every apps snapcraft.yaml, or should this be taken care of in kde-neon6?
Even with the shared-mem plug there are other apparmor denials, although they don't seem to prevent my app from functioning. Some are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
It looks like a better way to handle the apparmor shm denials is to use the browser-support interface instead of the shared-memory interface. Is that something that should be added to kde-neon6? Without one of these QtWebEngine won't work if apparmor is enforcing. |
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)Tests pass locally.