tests: drop grade: devel from core24 spread tests
#4750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/spread/core24/simple-snap tests `grade: stable` tests/spread/core24/craftctl/test-craftctl-get-set tests `grade: devel` and changing the grade via `craftctl` Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
force-pushed
the
work/core24-devel-spread
branch
from
638926b
to
7829b8c
Compare
mr-cal
requested review from
tigarmo,
lengau,
dariuszd21,
mattculler and
a team
and removed request for
tigarmo,
lengau,
dariuszd21 and
mattculler
lengau
approved these changes
May 30, 2024
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
commented
May 30, 2024
tigarmo
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)Simplify the
core24spread tests by droppinggradefrom all tests except fortests/spread/core24/craftctl/test-craftctl-get-set(which tests updating the grade).I added a new spread test to test the grade explicitly.