Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add issue for using ld from the base snap #4752

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Apr 22, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Update code comments for #4751

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.57%. Comparing base (6ff73a1) to head (781b66f).
Report is 49 commits behind head on main.

❗ Current head 781b66f differs from pull request most recent head 9c90f0b. Consider uploading reports for the commit 9c90f0b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4752      +/-   ##
==========================================
+ Coverage   89.54%   89.57%   +0.03%     
==========================================
  Files         337      331       -6     
  Lines       22638    22067     -571     
==========================================
- Hits        20271    19767     -504     
+ Misses       2367     2300      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal merged commit b040a15 into main May 9, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants