Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): add ROS 2 core22 extensions for remote-build #4756

Conversation

Guillaumebeuzeboc
Copy link
Contributor

@Guillaumebeuzeboc Guillaumebeuzeboc commented Apr 24, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Adds ROS 2 core22 extensions in the legacy schema for remote-build.

Referring to this commit: f509ac0

Remote-building always uses legacy and use the legacy schema to validate.

@Guillaumebeuzeboc
Copy link
Contributor Author

The failing test is google:ubuntu-24.04-64:tests/spread/core-devel/basic, unrelated to this PR.

@mr-cal mr-cal requested a review from cmatsuoka April 29, 2024 22:47
@Guillaumebeuzeboc
Copy link
Contributor Author

Hello, any news on this?

@mr-cal mr-cal requested review from lengau and removed request for lengau June 4, 2024 19:10
@mr-cal
Copy link
Collaborator

mr-cal commented Jun 4, 2024

Hello, any news on this?

Hey @Guillaumebeuzeboc, sorry for the delay. I'll ping @cmatsuoka for a review.

@cmatsuoka cmatsuoka merged commit b4ed5dd into canonical:main Jun 5, 2024
10 checks passed
@Guillaumebeuzeboc Guillaumebeuzeboc deleted the fix/core22_ros2_extensions_remote_build branch June 6, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants