Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update link for top level plug and slots warning #4765

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Apr 29, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Updates to the documentation and a better link based on @Saviq's feedback.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal requested review from tigarmo, lengau and mattculler and removed request for lengau April 29, 2024 13:08
Copy link
Contributor

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I would like to see some rationale, since it works fine if top-level, so ¯\_(ツ)_/¯

@mr-cal
Copy link
Collaborator Author

mr-cal commented Apr 29, 2024

FWIW I would like to see some rationale, since it works fine if top-level, so ¯_(ツ)_/¯

Context: https://forum.snapcraft.io/t/snapcraft-top-level-metadata/8334/11

I believe the long-term plan is for snapd to not apply globally-defined plugs and slots to each app.

@mr-cal mr-cal enabled auto-merge (squash) April 29, 2024 21:12
@mr-cal mr-cal disabled auto-merge April 29, 2024 22:21
@mr-cal mr-cal merged commit d9001c7 into main Apr 29, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants