Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow packing a directory #4794

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented May 7, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

This fixes a regression in snapcraft 8.2 where snapcraft pack <directory> stopped working.

Fixes #4769
(CRAFT-2861)

@mr-cal mr-cal force-pushed the work/pack-directory-fix branch 2 times, most recently from e1be2a8 to 4a0ef30 Compare May 8, 2024 15:56
@mr-cal mr-cal requested review from tigarmo and lengau and removed request for tigarmo May 8, 2024 16:33
snapcraft/commands/lifecycle.py Show resolved Hide resolved
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure whether you'll like my suggestion for reducing reimplementation in the PackCommand - I could take it or leave it.

snapcraft/commands/lifecycle.py Show resolved Hide resolved
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
Copy link
Collaborator Author

mr-cal commented May 8, 2024

Force pushing to drop extraneous commits.

@mr-cal mr-cal merged commit 48483c4 into hotfix/8.2 May 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants