Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extension: fix issues and depreciated vars in gnome extension #4798

Merged
merged 3 commits into from
May 10, 2024
Merged

extension: fix issues and depreciated vars in gnome extension #4798

merged 3 commits into from
May 10, 2024

Conversation

soumyaDghosh
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

@soumyaDghosh soumyaDghosh changed the title extension: fix GI_TYPELIB_PATH in gnome extension extension: fix issues and depreciated vars in gnome extension May 9, 2024
mr-cal
mr-cal approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mr-cal mr-cal requested a review from lengau May 9, 2024 14:00
@mr-cal mr-cal merged commit bc06b52 into canonical:main May 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@lengau lengau lengau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soumyaDghosh @lengau @mr-cal