Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow coreXX-desktop bases #4850

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: allow coreXX-desktop bases #4850

merged 1 commit into from
Jun 12, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Jun 11, 2024

Fixes #4818

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

@lengau lengau requested review from mr-cal and a team June 11, 2024 21:31
mr-cal
mr-cal approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@mr-cal mr-cal requested a review from a team June 11, 2024 21:53
@mr-cal mr-cal merged commit 61efc79 into main Jun 12, 2024
9 of 10 checks passed
@mr-cal mr-cal mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@tigarmo tigarmo tigarmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regresion: Can't build pc-amd64-gadget-desktop (neither 22 nor 24 versions) with snapcraft 8.x
3 participants
@lengau @tigarmo @mr-cal