fix(cli): properly capture store errors #4863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
force-pushed
the
work/store-errors
branch
2 times, most recently
from
677544c
to
fdb93a7
Compare
tigarmo
requested changes
Jun 19, 2024
tigarmo
approved these changes
Jun 19, 2024
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
When raised they show up as a Snapcraft internal error if not properly handled. This is using the same logic as in legacy. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
work/store-errors
branch
from
fdb93a7
to
f711ccf
Compare
cmatsuoka
approved these changes
Jun 19, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When raised they show up as a Snapcraft internal error if not properly
handled.
This is using the same logic as in legacy.