chore(merge): '8.2.12' into 'main' #4872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readthedocs builds don't fetch tags when cloning the repo. This is a problem for us because Snapcraft's version comes from the git tag, so do a fetch of the tags as a post-checkout step. Additionally, explicitly install snapcraft itself (via "pip install .") so that the code that gets the version from git actually runs. Note that this already works on "latest" because that builds off of "main" where this fix has already been applied (when moving to canonical-sphinx).
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
When raised they show up as a Snapcraft internal error if not properly handled. This is using the same logic as in legacy. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
commented
Jun 24, 2024
mr-cal
requested review from
tigarmo and
a team
and removed request for
a team and
tigarmo
sergiusens
approved these changes
Jun 24, 2024
tigarmo
approved these changes
Jun 25, 2024
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)Merge 8.2.12 into main
Needs a new craft-parts 1.32.0 release (canonical/craft-parts#762)