fix(expand-extensions): use the Application's project #5106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes LP bug https://bugs.launchpad.net/snapcraft/+bug/2083964 Instead of parsing the project again itself, expand-extensions now uses the project provided by the application. The output is changed slightly, but I believe it reflects a more accurate expansion.
lengau
force-pushed
the
work/lp-2083964
branch
from
b165507 to
c64cea8
Compare
mr-cal
approved these changes
Jan 15, 2025
This failure is a consequence of using pydantic validators to modify the data here. There's probably not a way around this error besides removing that validator. |
|
@mr-cal as a note I had to change some other tests for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LP bug https://bugs.launchpad.net/snapcraft/+bug/2083964
Instead of parsing the project again itself, expand-extensions now uses the project provided by the application. The output is changed slightly, but I believe it reflects a more accurate expansion.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)